input-remapper icon indicating copy to clipboard operation
input-remapper copied to clipboard

RelToAbs

Open jonasBoss opened this issue 3 years ago • 8 comments

needs tests

jonasBoss avatar Jul 25 '22 16:07 jonasBoss

This should be a good example for a RelToRelHandler

jonasBoss avatar Aug 29 '22 10:08 jonasBoss

"Remove the Analog Output Axis when specifying an macro or key output"

image

Is this error message related to this PR? I don't know what to do there

sezanzeb avatar Sep 03 '22 14:09 sezanzeb

ah, I had to switch to "Key or Macro" and clear the text input. Can we say that in the error message?

Now it shows a different error:

__root__ missing macro or key: the combination = <EventCombination (2, 1, -1)> specifies a key input, but no output macro or key is programmed (type=value_error)

image

sezanzeb avatar Sep 03 '22 14:09 sezanzeb

Those have nothing to do with this PR. I created #468 for this, there we can collect all the problematic error messages and fix them.

jonasBoss avatar Sep 03 '22 14:09 jonasBoss

what should I do about the second error message in order to try the RelToAbs handler out?

sezanzeb avatar Sep 03 '22 17:09 sezanzeb

You need to configure the input as axis Analog input. Go to the Advanced Input Configuration and set the switch to "Use as Analog"

jonasBoss avatar Sep 03 '22 18:09 jonasBoss

If no input is used as analog, but the mapping maps to "Analog Axis", can we default to using the first analog input as analog axis?

I think user experience is really one of the most important things in software. If we can somehow make it easier for people to use it I'm all for it.

sezanzeb avatar Sep 09 '22 12:09 sezanzeb

I can see what I can come up with.

jonasBoss avatar Sep 14 '22 17:09 jonasBoss

I just updated the GUI. It will now show a message when the user switches between "Key or Macro" and "Analog axis" and it will remove the macro input or the axis input to avoid errors. It is not perfect, the user still needs to update the input accordingly but hopefully it clears up some confusion.

This needs some integration tests.

jonasBoss avatar Sep 28 '22 13:09 jonasBoss

@sezanzeb can you have another look at this? Should be ready.

jonasBoss avatar Sep 29 '22 12:09 jonasBoss

great! Thanks. It was easy to set it up

Can you please add a tooltip to "Output Axis" that says something like "Available output axes are affected by the Target setting."? I'll merge it then

sezanzeb avatar Oct 02 '22 14:10 sezanzeb

I just started working on the new UI, I'll add the tooltip later

sezanzeb avatar Oct 02 '22 15:10 sezanzeb