sewenew

Results 163 comments of sewenew

This seems great! I'll test on multiple environment ASAP. Also can you remove the changes on the *.gitignore* file? This seems specific to your building environment. Thank you very much...

Hi @langep I tried your CMakeLists.txt. However, it failed to build the test on Centos 7 GCC 4.8.5, with `REDIS_PLUS_PLUS_BUILD_HIREDIS_FROM_SUBMODULE` **OFF**. The following is the error message: ``` /usr/bin/ld: cannot...

Hi @wingunder I just tried @langep 's patch again with 3 different compilers, and the result is interesting. - Apple clang version 11.0.0 (clang-1100.0.33.12) + cmake version 3.10.1 - gcc...

Hi @wingunder Thanks for the info. I'll let you know, when I have progress on this. Regards

@HHcamel You only need to ensure that the configured node is alive when `RedisCluster` is initialized. Once `RedisCluster` connects the node, and gets the slot-node mapping, it does not matter...

@wingunder In fact, we don't need to use Redis Sentinel to do failover for nodes in Redis Cluster, since Redis Cluster will do the failover by the nodes in the...

@wingunder If RedisCluster already connects to the cluster, it works normally even if the node is gone. Because it will get the new master address from other nodes in the...

@HHcamel Yes, that's a potential problem. In that case, `RedisCluster` will throw exception, and you need to update the ip:port manually, i.e. create another `RedisCluster`. I might try to make...

@wingunder It's a very nice idea by setting the failover timeout long enough, to avoid failover conflict! This looks like a hidden feature, since no document mentioned this deployment. The...

Sorry, but it seems that this is a new feature of CMAKE, and I don't have a newer version of CMAKE to test it. I did some research, and it...