Consider IHttpClientFactory instead of static HttpClient

[dahlbyk]

https://docs.microsoft.com/en-us/aspnet/core/fundamentals/http-requests

https://www.nuget.org/packages/Microsoft.Extensions.Http

[severisv]

How to support applications that don't use IHttpClientFactory? Would we have to attempt to resolve it, but default to a static one when we are unable to?

[dahlbyk]

How to support applications that don't use IHttpClientFactory? Would we have to attempt to resolve it, but default to a static one when we are unable to?

I think AddHttpClient() is designed to be able to support something like this:

    public static class SlackConfiguration
    {
        public static ILoggingBuilder AddSlack(this ILoggingBuilder builder)
        {
            builder.Services.AddHttpClient(nameof(SlackLogger));
            builder.Services.AddTransient<ILoggerProvider, LoggerProvider>();

            return builder;
        }
    }

    internal class SlackService
    {
        private async Task PostAsync(/* ... */)
        {
            // ...
            var httpClient = _httpClientFactory.CreateClient(nameof(SlackLogger));
            await httpClient.PostAsync(url, content).ConfigureAwait(false);
        }
    }

Or SlackService could be refactored as a transient typed client that would be directly injected into SlackLogger.Logger instead of newed up.

Glad to take a shot at an implementation. The project I'm currently using this on doesn't use IHttpClientFactory.

[severisv]

Allright, that sounds good ☺

[dahlbyk]

I do still plan to get back to this. Someday.™