overlap icon indicating copy to clipboard operation
overlap copied to clipboard

feat: unify implementation of polyhedra

Open severinstrobl opened this issue 11 months ago • 3 comments

severinstrobl avatar Mar 24 '24 13:03 severinstrobl

Codecov Report

Attention: Patch coverage is 89.35065% with 41 lines in your changes are missing coverage. Please review.

Project coverage is 91.85%. Comparing base (ad9bde3) to head (a81983f). Report is 39 commits behind head on develop.

Files Patch % Lines
include/overlap/overlap.hpp 89.35% 12 Missing and 29 partials :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #87      +/-   ##
===========================================
- Coverage    93.30%   91.85%   -1.46%     
===========================================
  Files            1        1              
  Lines          851      908      +57     
  Branches       156      173      +17     
===========================================
+ Hits           794      834      +40     
- Misses          10       16       +6     
- Partials        47       58      +11     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 24 '24 15:03 codecov[bot]

C++ benchmark results

Benchmark Reference (bfc27d6d88805851f351f16e337c721c559a2767) Current (3cd9170240f26d1752ee64d444dbc62045727ff7)
hex_overlap_volume 3.04 us 3.28 us: 1.08x slower
hex_overlap_volume_aabb 8.38 ns 7.14 ns: 1.17x faster
tet_overlap_volume 1.28 us 1.67 us: 1.30x slower
tet_overlap_volume_aabb 5.57 ns 4.98 ns: 1.12x faster
Geometric mean (ref) 1.01x slower

Benchmark hidden because not significant (2): normal_newell, regularized_wedge

github-actions[bot] avatar Mar 24 '24 21:03 github-actions[bot]