bible_api icon indicating copy to clipboard operation
bible_api copied to clipboard

Modern book names in translation queries

Open nivaca opened this issue 5 years ago • 2 comments

Currently to use the API to query for a translation, one has to use the target language's book names, e.g.:

http://bible-api.com/Joannes+3:16?translation=clementine

Whereas using the English names of those books does not work:

http://bible-api.com/John+3:16?translation=clementine

Could the API be fixed so it does work? (I usually don't recall the Latin names of all the books from the Vulgata).

Thanks.

nivaca avatar Jul 05 '20 19:07 nivaca

Thanks for the issue. It's been awhile since I worked on this, but I think the solution is to update this file: https://github.com/seven1m/bible_ref/blob/master/lib/bible_ref/languages/latin.rb

It should look something more like this one: https://github.com/seven1m/bible_ref/blob/master/lib/bible_ref/languages/portuguese.rb

If you are able to help, I would accept a PR over on the bible_ref repository! If not, I will get around to it someday...

seven1m avatar Jul 06 '20 23:07 seven1m

Sure, I'll give it a try. Best.

nivaca avatar Jul 06 '20 23:07 nivaca