bible_api icon indicating copy to clipboard operation
bible_api copied to clipboard

Exodus 1:1 kjv has a newline in the middle of it

Open Zachiah opened this issue 4 years ago • 5 comments

go to http://bible-api.com/Exodus+1:1?translation=kjv and it has a random newline in the middle

Zachiah avatar Feb 21 '20 16:02 Zachiah

I'd noticed that before; it comes from the source material which is in the file eng-kjv.osis.xml here: https://github.com/seven1m/open-bibles/

<verse osisID="Exod.1.1" sID="Exod.1.1.seID.01585" n="1" />Now these
<transChange type="added">are</transChange> the names of the children of Israel, which came into Egypt; every man and his household came with Jacob.

I think it would be safe to strip newlines from the XML during parsing. I'll see about doing that.

Thanks for the bug report!

seven1m avatar Feb 21 '20 21:02 seven1m

Thank you you might be able to just replace all whitespace with a space because john 3:16 kjv for example also starts with a margin

Zachiah avatar Feb 25 '20 22:02 Zachiah

for now I'll just use text.strip.gsub("\n"," ") in my rails app

Zachiah avatar Feb 25 '20 23:02 Zachiah

Extra examples:

  • Revelation 22:21
  • John 3:16

seven1m avatar Jul 20 '20 01:07 seven1m