bible_api icon indicating copy to clipboard operation
bible_api copied to clipboard

Request url for book with number

Open stefanauwyang opened this issue 7 years ago • 2 comments

On top of '1 chronicles' and '2 chronicles' as input, may be can consider to add 'first chronicles' and 'second chronicles'. Also for the rest of the multiple books. Thanks :)

stefanauwyang avatar Jun 17 '17 14:06 stefanauwyang

I also have a use case for this - although i can easily work around it, so it's not necessary. https://github.com/meichthys/sword_drill/issues/5

meichthys avatar Mar 22 '21 02:03 meichthys

On top of '1 chronicles' and '2 chronicles' as input, may be can consider to add 'first chronicles' and 'second chronicles'. Also for the rest of the multiple books. Thanks :)

I would recommend processing your input before making the request. You're reducing complexity for @seven1m, alleviating processing on the API/server, reducing overhead during transport and it isn't as costly to process it on your input. I had a similar use case and decided to address it with an array of all the books and included possible variations (i.e. array is greater than the 66 books). The added benefit is you can also handle future (language) translations should you take on the enhancement.

johndoesniper avatar Jul 26 '21 06:07 johndoesniper