capistrano-sidekiq icon indicating copy to clipboard operation
capistrano-sidekiq copied to clipboard

Add an option to disable monit configuration

Open kraft001 opened this issue 7 years ago • 5 comments

Solves #181 Allows a user to skip the monit configuration step if monit was already configured on the server

kraft001 avatar Jan 22 '18 07:01 kraft001

This controversy to #193. IMO, sidekiq monit conf MUST be re-upload on every deploy automatically. Suppose you changed some sidekiq options that should be reflected in monit start command inside monit config file, e.g. sidekiq_concurrency or sidekiq_logfile.

Tensho avatar Apr 03 '18 14:04 Tensho

@Tensho I completely agree with your point, it's valid when a developer has access to monit config files. But in our case monit is managed by sysadmins who built their own Puppet scripts, and developers cannot change those scripts. More options don't hurt but help developers to handle such cases.

kraft001 avatar Apr 03 '18 15:04 kraft001

@kraft001 ah, I see what you mean. In such a case it makes sense, even though sysops should reflect (sync) any configuration changes developers introduced by hand in this case. Does capistrano-unicorn or capistrano-puma have the similar configuration option?

Tensho avatar Apr 03 '18 15:04 Tensho

@Tensho Neither of the mentioned gems has such an option

kraft001 avatar Apr 03 '18 19:04 kraft001

@kraft001 🤔 Maybe conventionally deploy should be run from Puppet system either... I don't see any significant drawbacks incurring this config option. Could you please rebase the branch?

@seuros, What do you think on the subject?

Tensho avatar Apr 04 '18 06:04 Tensho