capistrano-sidekiq icon indicating copy to clipboard operation
capistrano-sidekiq copied to clipboard

Add support role specific configuration values

Open kpheasey opened this issue 8 years ago • 4 comments

Add support role specific configuration values for the following options:

  • :sidekiq_env
  • :sidekiq_log
  • :sidekiq_require
  • :sidekiq_tag
  • :sidekiq_queue
  • :sidekiq_config
  • :sidekiq_concurrency
  • :sidekiq_option_per_process
  • :sidekiq_options

kpheasey avatar Jul 13 '16 18:07 kpheasey

@seuros Just wanted to add that this is a more complete solution for role specific configuration as compared to the following pending pull requests. Additionally, It uses the [role]_[option] naming scheme that is already being implemented with :sidekiq_processes

  • https://github.com/seuros/capistrano-sidekiq/pull/149
  • https://github.com/seuros/capistrano-sidekiq/pull/141
  • https://github.com/seuros/capistrano-sidekiq/pull/117
  • https://github.com/seuros/capistrano-sidekiq/pull/85

kpheasey avatar Jul 15 '16 00:07 kpheasey

+1 When will this be merged?

joelmats avatar May 07 '17 10:05 joelmats

Same question

AlexanderFisenko avatar Oct 19 '17 16:10 AlexanderFisenko

hi @seuros, is there an alternative way to support this in the current version, I been using a fork from @kpheasey for over a year and things worked fine, however, I'm now upgrading to latest Capistrano and I'm facing the issue you fixed here https://github.com/seuros/capistrano-sidekiq/issues/160.

if you think this is a feature that will contribute to the project, I'm more than glad to help reforking and applying @kpheasey changes to latests version.

in my case I use different configs not only for a different number of process per machine size, but i distribute the queues to different machines, critical and fast processing queues go to one machine role and the non-critical or heavy process such export go to a different set of machines.

lustercr avatar Jun 20 '18 16:06 lustercr