capistrano-sidekiq
capistrano-sidekiq copied to clipboard
Get sidekiq_pid value by reading sidekiq_config
Currently, even if I specify a pidfile
value in my sidekiq.yml file, I'm forced to also set a sidekiq_pid
value for capistrano-sidekiq. If I don't set a sidekiq_pid
value, capistrano-sidekiq actively tells sidekiq to use capistrano-sidekiq's default pidfile location, ignoring my sidekiq.yml value.
This pull has capistrano-sidekiq pick a pidfile in the following order
- A user-set
sidekiq_pid
value (plus any index number) - If a user sets a
sidekiq_config
value, anypidfile
entry for the currentsidekiq_env
- If a user sets a
sidekiq_config
value, any globalpidfile
entry - The default pidfile location (plus any index number)
This Pull request should also address
- Issue #134 - because the value from their sidekiq.yml will be honored
- @edslocomb's problems caused by Pull #116 [1][2]
- Partially addresses Issue #44 - So long a the user specifies unchanging pidfiles in the config file for each process, they'll be able to add processes as needed without worry about pidfile values changing. I'll be creating a new pull request in a bit that allows users to specify a config file per process.