v0.0.18 | Supports Texture Coordinates and Normals

[farunurisonmez]

#5 Can it encode normal or uv?

• [x] Decode supports Texture Coordinates and Normals
• [ ] Encode supports Texture Coordinates and Normals

Co-Authored-By: Faru Nuri Sönmez [email protected]

[william-silversmith]

Hi Faru!

I'm the new maintainer for this repo and I'll be happy to review your PR! I'm a bit less experienced with the Draco spec compared with the library creator, so I might need some tips to help review. ^_^

I'll leave some comments on the PR. Would you mind also adding an automated test?

Thanks!! Sorry it took so long to get this reviewed.

[william-silversmith]

Thanks again for this valuable contribution!

[william-silversmith]

Hi Faru! I adopted some of your changes (the normal decode) and gave you a credit in the setup.py file! I was working rapidly so I didn't adopt the textures as I wasn't sure how to test it. Thanks for your contribution!

[william-silversmith]

Sorry, closed by mistake when I meant to comment.

[cansik]

@william-silversmith Thank you very much for further upgrading the library, would it be possible to add UV / texture support as well? If you need an example script / files I could provide it to you for testing.

[william-silversmith]

Hi Florian, I'd be happy to consider adding it. A script and data would help tremendously!

On Sat, Apr 9, 2022, 12:05 PM Florian Bruggisser @.***> wrote:

@william-silversmith https://github.com/william-silversmith Thank you very much for further upgrading the library, would it be possible to add UV / texture support as well? If you need an example script / files I could provide it to you for testing.

— Reply to this email directly, view it on GitHub https://github.com/seung-lab/DracoPy/pull/17#issuecomment-1094075456, or unsubscribe https://github.com/notifications/unsubscribe-auth/AATGQSJKC3USLB6B7XANIADVEGTFFANCNFSM44K7IY7Q . You are receiving this because you were mentioned.Message ID: @.***>