Setup-Your-Mac icon indicating copy to clipboard operation
Setup-Your-Mac copied to clipboard
verified publisher icon setup-your-mac

Incorrect failure message displayed

Open arnoldtaw opened this issue 1 year ago • 2 comments

Describe the bug Upon detecting a failure, the correct failure message was not displayed. Instead, it displayed the placeholder text. Placeholder message; update in the 'finalise' function

To Reproduce Unable to reproduce consistently. Correct customized failure message was displayed in most cases. Once in a while, we will get this message.

Expected behavior Upon detecting a failure, display the correct failure message.

Code/log output N/A

Screenshots Screenshot 2024-05-07 at 8 26 23 AM

Environment:

  • macOS 14.4.1
  • Script version 1.14.2
  • swiftDialog 2.4.2

arnoldtaw avatar May 07 '24 15:05 arnoldtaw

I'm consistently running into this bug. Glad it's already been identified. Happy to assist with troubleshooting.

jcmbowman avatar May 13 '24 14:05 jcmbowman

Fixed on my end by changing sleep time to 0.7 here: https://github.com/setup-your-mac/Setup-Your-Mac/blob/084c8293115df89fd9db0343cacb45ec99b01631/Setup-Your-Mac-via-Dialog.bash#L1719

jcmbowman avatar May 14 '24 13:05 jcmbowman

@arnoldtaw: While I'm aware of other reports of this unexpected behavior, I'm not able to replicate it.

That said, please advise if 1.15.0-b7 resolves the issue.

Thanks.

dan-snelson avatar May 28 '24 19:05 dan-snelson

Addressed in SYM 1.15.0.

dan-snelson avatar Jun 07 '24 09:06 dan-snelson