ulozto-downloader
ulozto-downloader copied to clipboard
Corectly remove output_filename+DOWNPOSTFIX (.udown) file
<output_file>.udown not removed after all segments downloaded. After continue already downloaded file this cause of error:
`Terminating download. Please wait for stopping all threads.9-6-0-amd64-netinst-iso Exception in thread Thread-1 (run):ownload Traceback (most recent call last):82MB File "/home/vlado/.local/lib/python3.10/site-packages/uldlib/frontend.py", line 111, in run self._loop(info, parts, stop_event)10/site-packages/uldlib/frontend.py", line 111, in run File "/home/vlado/.local/lib/python3.10/site-packages/uldlib/frontend.py", line 223, in _loop speed = (s - s_start) / elapsed if elapsed > 0 else 0ldlib/frontend.py", line 223, in _loop UnboundLocalError: local variable 's' referenced before assignment UnboundLocalError: local variable 's' referenced before assignment During handling of the above exception, another exception occurred:
Traceback (most recent call last): File "/usr/lib/python3.10/threading.py", line 1016, in _bootstrap_inner self.run() File "/usr/lib/python3.10/threading.py", line 953, in run self._target(*self._args, **self._kwargs) File "/home/vlado/.local/lib/python3.10/site-packages/uldlib/frontend.py", line 120, in run terminate_func() File "/home/vlado/.local/lib/python3.10/site-packages/uldlib/downloader.py", line 57, in terminate self.captcha_thread.join() File "/usr/lib/python3.10/threading.py", line 1091, in join raise RuntimeError("cannot join thread before it is started") RuntimeError: cannot join thread before it is started `
Autodetection of full tensorflow :+1:, thanks for that :)
Thinking about tflite-runtime
versus full tensorflow
packages and the extras requirements. Even on Windows the tflite-runtime
could be installed for Python 3.8 and older (see #101). And to accidentally install lot of GBs of full tensorflow could be annoying.
Maybe we could specify extra targets like this?
extras_require={
"auto-captcha": ["tflite-runtime"],
"auto-captcha-full": ["tensorflow"]
},
And add some quick "what version to choose" section in the README? (but leave the decision "I want to install a lot of GBs" to the user)
And what do you plan to include in this pull request at all? What do you need to solve before it would be ready for full review and merge?
Do we really need to remove .udown? We do not remove even the .ucache file at this time. I think .udown is needed for the purposes of having another Frontend implementation such as Rest API, where you would need to serve the file while downloading and that requires presence of .udown.