trivrost
trivrost copied to clipboard
installdown: version should be taken from launcher-config
Installdown gets launcher info for embedding into MSI meta info from a variable determined during Makefile execution. The value is both incorrect and also not the one we want. It should be taken from launcher-config instead.
It defaults to the configured launcher-config (https://github.com/setlog/trivrost/blob/b02b46f98fa25deca67379ee67351d30e0cc07f5/cmd/installdown/main.go#L171) and this is also passed in the makefile (https://github.com/setlog/trivrost/blob/ccea1e7a0e5815bd1c519e6ecc7ecf9da2e81827/Makefile#L126)
Could you explain what you mean? I do not see the problem.