campus-space icon indicating copy to clipboard operation
campus-space copied to clipboard

feat: Edit rooms

Open Sid-80 opened this issue 1 year ago • 7 comments

Issue

resolves #32

Description :

Implementation of modal form for updating the room information.

Video :

https://github.com/sethshivam11/campus-space/assets/101277141/c709d852-1332-4fdc-8f23-0ff6febac85b

Sid-80 avatar Jun 29 '24 13:06 Sid-80

@sethshivam11 Please review!! Let me know if any changes required!!

Sid-80 avatar Jun 29 '24 13:06 Sid-80

@Sid-80 Please fix the gap between the cancel and submit button.

sethshivam11 avatar Aug 03 '24 14:08 sethshivam11

@sethshivam11 Changes are up. Please review it!!

Sid-80 avatar Aug 04 '24 12:08 Sid-80

@sethshivam11 ?

Sid-80 avatar Aug 06 '24 09:08 Sid-80

@Sid-80 Okk, I am checking it.

sethshivam11 avatar Aug 06 '24 11:08 sethshivam11

@Sid-80 RoomProvider.tsx file -

  1. Instead of checking the res.status === 200, you should use res.data.success for the sake of consistency .
  2. Use the spread operator and try to update the specific room, instead of just running the fetchRoom function in if block.

EditTeamModal.tsx file -

  1. Use Dialog box instead of an AlertDialog (Because the UI is breaking).
  2. Buttons having text should be wrapped inside of a DialogFooter (if you use Dialog).
  3. Buttons having text Submit should have "Update".

EditTeamForm.tsx file -

  1. Since I haven't used zod or react-hook-form you should remove it, in order to maintain consistency and save the space (for a single feature you have added 2-3 packages).

I hope you'll understand and keep the codebase maintained for the others as well.

sethshivam11 avatar Aug 06 '24 12:08 sethshivam11

@Sid-80 Are you working on it?

sethshivam11 avatar Aug 08 '24 11:08 sethshivam11