Quotes-Generator icon indicating copy to clipboard operation
Quotes-Generator copied to clipboard

Published 20 hours ago • verified publisher icon seths10

Any Other Feature

Open seths10 opened this issue 2 years ago • 13 comments

I'm accepting any other features that you may want to add to the repository

seths10 avatar Oct 13 '22 13:10 seths10

I would like to add a feature where a user can download the quote as an image. I think that would be great as some users want to download the quote and then they can share it anywhere else.

burhanharoon avatar Oct 13 '22 16:10 burhanharoon

Can I add a feature of q quote shrinking and growing?

Such6 avatar Oct 13 '22 17:10 Such6

@Such6 go ahead and submit a valid PR, I will merge it.

seths10 avatar Oct 15 '22 17:10 seths10

@burhanharoon that will be very great, can wait to test it out. Go ahead,i will be waiting for a PR from you.

seths10 avatar Oct 15 '22 17:10 seths10

Sure!

burhanharoon avatar Oct 15 '22 18:10 burhanharoon

I'm reviewing it, I will merge it soon

seths10 avatar Oct 16 '22 20:10 seths10

Sure!

burhanharoon avatar Oct 16 '22 20:10 burhanharoon

@burhanharoon I've merged your pull request

seths10 avatar Oct 18 '22 20:10 seths10

Sounds great!

burhanharoon avatar Oct 18 '22 20:10 burhanharoon

@seths10 Not really a feature per say but what do you think about setting up github actions, husky and eslint for this repo?

ishita1805 avatar Oct 25 '22 05:10 ishita1805

@ishita1805 that sounds great

seths10 avatar Oct 25 '22 20:10 seths10

@seths10 Here's my PR, lemme know what you think https://github.com/seths10/Quotes-Generator/pull/168

ishita1805 avatar Oct 30 '22 18:10 ishita1805

I think that's a great Idea to add a feature. But we also need to focus on the point that our code isn't fully organised and their are some other ES6 method that can be used for re-writing the code, so that we'll have higher chances of preventing errors and bug. Thank You @ishita1805 @seths10

niikkhilsharma avatar Mar 27 '23 03:03 niikkhilsharma