Quotes-Generator icon indicating copy to clipboard operation
Quotes-Generator copied to clipboard

Rewriting code for better functioning.

Open niikkhilsharma opened this issue 2 years ago • 2 comments

https://github.com/seths10/Quotes-Generator/blob/main/index.html The download Image method in the above HTML file is copied from here. https://vincent7128.github.io/text-image/

I suggest it should be written again, so that it would work better. And it is also used as an style in the same html file. We should maintain the file, and so the code for download image should also be written in script.js file. This would help us maintaining the code and keep it better and simple.

This issue can be solved in two steps: Step 1. Putting the script code from the index.html file to script.js file Step 2. Rewriting the code for downloading the quote as image.

I am ready to take this issue and fix it. Thank You @bruceyboy86 @seths10

niikkhilsharma avatar Mar 27 '23 04:03 niikkhilsharma

can i work on this issue

ashish07-07 avatar Oct 31 '23 07:10 ashish07-07

@niikkhilsharma I think I have implemented the your desired changes, @seths10 can you review it?

emiedonmokumo avatar May 12 '24 22:05 emiedonmokumo