Seth R. Johnson
Seth R. Johnson
CMS external with Celeritas+CUDA from 2023: https://github.com/cms-sw/cmsdist/compare/IB/CMSSW_15_1_X/master...whokion:cmsdist:celeritas-add-shared
@sanmayphy @whokion @kpedro88 v0.6.3 is released and should hopefully fix the logger initialization error that Sanmay saw. We can keep using the singleton as a starting point as one of...
See #1642, #1638 , #1617, #1271
@wdconinc noticed that hepmc files don't work properly in the `.mac` input. This is related to this issue and #1390 and the refactoring of the hepmc3 generators. I think we...
Thanks @esseivaju for the forward (and thanks @mnovak42 for the difficult footwork!) It looks like there's only one SD requirement there, the LV from the vertex; the other requirements can...
@Rashika-Gupta could you merge upstream/develop and mark as "resolved" all the comments you've addressed? Thanks!
@davidsgr I see an IWYU error causing a build failure: https://github.com/celeritas-project/celeritas/actions/runs/18719387226/job/53387353724?pr=2001 missing `` I think. Could you ensure all the CI tests pass while I review this morning? Thanks!
@davidsgr Since the last review it looks like you've moved a lot of stuff in to `.cc` files: this unfortunately *will not work* in Celeritas. All code that's used inside...
@davidsgr Did you see the comments above? Not sure if you're waiting on another review and there are several comments unresolved. I'll merge once they're addressed. Regarding the cmake, have...
@davidsgr I took the liberty of adding some documentation (and moving the Impl file to engine/detail where it more closely belongs). Please `git pull --rebase` on your local branch!