Seth R. Johnson

Results 366 comments of Seth R. Johnson

@esseivaju Regarding your questions today about infix: 1. Let's get the building blocks in to the point where we can throw a switch to activate it. 2. Add an enum...

@esseivaju Sorry I was very sloppy in how I phrased that. By "throw a switch" I meant e.g. "find-replace LogicEvaluator with InfixEvaluator" inside the runtime code. For point one, I...

Since the generator/pregenerator code already has polarization in there, I'm taking back what I said about removing it—sorry @hhollenb about the flip-flop and sorry this PR has taken so long....

@amandalund Could you give a last quick once-over and hit the auto-merge button if it looks good? Thanks!

I went ahead and updated with the rejection sampler to speed this up (and take a little work off your sholders!): @hhollenb the reduced rejection rate here looks correct to...

@hhollenb thanks for the plot. It's not surprising the distributions are different since we changed "accept when" to "reject when", as @amandalund suggested. The question is whether the new distribution...

@drbenmorgan I think your plan for a separate struct (and later creating another one for EM parameters) is perfect. Thanks for this!

@drbenmorgan To make life easier for now, let's just stick to the newer versions, and we can throw a "not implemented" for the older versions if the experiments still need...

Sorry I pulled the trigger too soon!

@whokion @pcanal Do you know much about how internal reflection for optical photons (or other particles for that matter; I think neutrons can do it too under the right circumstances)...