truststore icon indicating copy to clipboard operation
truststore copied to clipboard

[drive-by CI improvement suggestion] Implement a unified gate check for branch protection

Open webknjaz opened this issue 1 year ago • 3 comments

I have a thing (https://github.com/marketplace/actions/alls-green#why — a shameless plug; you might've seen it integrated in CPython, pip, cryptography, etc.) that allows consolidating results of CI matrixes into a single gate.

The reason I'm bringing this up is that I noticed that only a portion of jobs are marked as required in PRs so it is likely that updating branch protection after updating the CI job definitions slipped off the radar.

This could be a good first issue for an external contributor, requiring just a little GHA experience.

webknjaz avatar May 30 '24 13:05 webknjaz

Thanks @webknjaz. Updating the branch protection rules requires admin permissions on the repository, so I think @sethmlarson has to do it.

davisagli avatar May 30 '24 14:05 davisagli

The workflow/job definition can be implemented separately. But the final bit would require an admin, yes.

webknjaz avatar May 30 '24 16:05 webknjaz

@webknjaz Ah, I misunderstood -- you're not merely proposing adding the jobs that are currently not required, but adding your tool to help make sure this doesn't need as much maintenance in the future. That sounds interesting to me.

davisagli avatar May 30 '24 16:05 davisagli