Seth Axen
Seth Axen
@wsmoses [e6fa10b](https://github.com/EnzymeAD/Enzyme.jl/pull/1282/commits/e6fa10b62ff0c408e346082dca1b543733fe354c) marked some formerly broken EnzymeTestUtils tests as passing, but they were still failing when that PR was merged. Should that commit be reverted?
@wsmoses this PR is stalled pending answers to the questions in https://github.com/EnzymeAD/Enzyme.jl/pull/1327#discussion_r1516000282 and https://github.com/EnzymeAD/Enzyme.jl/pull/1327#issuecomment-1979737864
> > @wsmoses [e6fa10b](https://github.com/EnzymeAD/Enzyme.jl/pull/1282/commits/e6fa10b62ff0c408e346082dca1b543733fe354c) marked some formerly broken EnzymeTestUtils tests as passing, but they were still failing when that PR was merged. Should that commit be reverted? > > Yeah...
Got it. Since it currently prevents us from testing the changes here, I'll pick this up again when the EnzymeTestUtils CI passes on master.
Don't merge yet, need to resolve a bug on v1.7 first.
> Don't merge yet, need to resolve a bug on v1.7 first. Found it, it's the example in #1394
@wsmoses I added some more tests and tweaked some docstrings. I also needed to fix the random seed to get tests to pass. This is now ready to merge and...
Narrowing it down a bit more, Enzyme does not seem to like the `::Type{T}` annotation in the method. Without it it is fine: ```julia julia> using Enzyme, LinearAlgebra julia> A...
Agreed, also I believe this rule assumes `NoPivot`, so you probably want to just target this method: https://github.com/JuliaLang/julia/blob/688ae0a58361889feedcff9eeb5ff1e1b710906b/stdlib/LinearAlgebra/src/cholesky.jl#L267-L271. You perhaps can expand the wrapped type from `Matrix` to `StridedMatrix`, and...
> Without some better tooling the effort of writing these rules is not sustainable for me. > @sethaxen would you have cycles to work with @simsurace to set up the...