ExponentialAction.jl icon indicating copy to clipboard operation
ExponentialAction.jl copied to clipboard

Potential typo

Open colinfang opened this issue 9 months ago • 1 comments

In https://github.com/sethaxen/ExponentialAction.jl/blob/v0.2.8/src/parameters.jl#L54

Aᵖ⁺¹ = A * A
d = t_norm * sqrt(opnormest1(A))

Should A here be Aᵖ⁺¹ instead?

Because we are calculating the 1-norm for A^2 as in $d_p = \lVert A^p \rVert ^{1/p}$ for $p = 2$

colinfang avatar May 09 '24 20:05 colinfang

Thanks for the issue! I'll need to make a detailed comparison with the paper to be sure, but this indeed looks like it could be a mistake. Would be nice to find a case where this yields inaccurate results.

sethaxen avatar May 13 '24 09:05 sethaxen

Fixed by #29

sethaxen avatar Aug 19 '24 12:08 sethaxen