seshubaws

Results 18 comments of seshubaws

Hello @rhbecker, thanks for the comment! We are currently pausing reviewing and merging most external PRs due to prioritizing Re:Invent launches. We will be able to look at this PR...

@rjkerrison seems there's a linting error ``` make: *** [lint] Error 1 samcli/lib/providers/sam_function_provider.py:895:121: E501 Line too long (125 > 120) | 893 | def _set_templates_changed(self, paths: List[str]) -> None: 894...

Hi @sanyamk23 thank you for looking into this! I think your design sounds good, we can just pass both new properties to through to the LogGroup resource to be set...

@SherrryX Hello, thank you for your work on this PR! Could you please update based on Renato's comment so we can merge this?

Hi @shareefer thank you for reporting this! I haven't been able to reproduce this, but it would be helpful if you could let us know if were you able to...

Hi @shareefer thanks for providing more details, I was able to repro this. It seems that the debugging container that VSCode is creating is not mounting correctly when using Finch....

Merge blocked on compatibility issue with gradle 9.0.0

Hi @Fares-Abubaker, thank you for clarifying! So it seems setuptools wasn't included for Python 3.12+ (https://github.com/edmorley/get-pip/commit/2f463eb7e795d395a72f690eafca41b1b1fa8ea4). So in theory for Python 3.11 and lower, we don't need to add setuptools,...