servo icon indicating copy to clipboard operation
servo copied to clipboard

Incorrect deletion logic; it should be restricted using `self.viewport_description.`

Open kongbai1996 opened this issue 1 month ago • 4 comments

Incorrect deletion logic; it should be restricted using self.viewport_description.

Originally posted by @kongbai1996 in https://github.com/servo/servo/pull/39868#discussion_r2488543053

kongbai1996 avatar Nov 04 '25 03:11 kongbai1996

I added a restriction for self.viewport_description in the latest code's adjust_pinch_zoom function, but the page still zooms. The developer of this feature, @shubhamg13 , will continue to investigate the cause.

kongbai1996 avatar Nov 04 '25 06:11 kongbai1996

@servo-highfive assign me. I am working on it.

kongbai1996 avatar Nov 04 '25 07:11 kongbai1996

Hey @kongbai1996! Thanks for your interest in working on this issue. It's now assigned to you!

servo-highfive avatar Nov 04 '25 07:11 servo-highfive

#40098 This PR can fix the issue.

kongbai1996 avatar Nov 04 '25 07:11 kongbai1996