servo icon indicating copy to clipboard operation
servo copied to clipboard

Remove redundant memory allocation in Node::insert

Open MegaCorn opened this issue 10 months ago • 3 comments

If the inserted node is not a fragment, unnecessay vector memory allocation will cause 20% performance degradation

Testing: By comparing flame graph Fixes: https://github.com/servo/servo/issues/37223

MegaCorn avatar Jun 09 '25 03:06 MegaCorn

🔨 Triggering try run (#15562670467) for OpenHarmony

github-actions[bot] avatar Jun 10 '25 14:06 github-actions[bot]

🐰 Bencher Report

Branchmain
TestbedHUAWEI Mate 60 Pro

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds flag.

Click to view all benchmark results
BenchmarkLatencymilliseconds (ms)MemoryBytes
E2E/https://www.google.com/JS/gc-heap/admin📈 view plot
⚠️ NO THRESHOLD
23,840.00
E2E/https://www.google.com/JS/gc-heap/decommitted📈 view plot
⚠️ NO THRESHOLD
573,440.00
E2E/https://www.google.com/JS/gc-heap/unused📈 view plot
⚠️ NO THRESHOLD
49,464.00
E2E/https://www.google.com/JS/gc-heap/used📈 view plot
⚠️ NO THRESHOLD
401,832.00
E2E/https://www.google.com/JS/malloc-heap📈 view plot
⚠️ NO THRESHOLD
2,862,451.00
E2E/https://www.google.com/JS/non-heap📈 view plot
⚠️ NO THRESHOLD
262,144.00
E2E/https://www.google.com/LayoutThread/box-tree📈 view plot
⚠️ NO THRESHOLD
101,488.00
E2E/https://www.google.com/LayoutThread/display-list📈 view plot
⚠️ NO THRESHOLD
0.00
E2E/https://www.google.com/LayoutThread/font-context📈 view plot
⚠️ NO THRESHOLD
4,040.00
E2E/https://www.google.com/LayoutThread/fragment-tree📈 view plot
⚠️ NO THRESHOLD
112.00
E2E/https://www.google.com/LayoutThread/stylist📈 view plot
⚠️ NO THRESHOLD
5,264.00
E2E/https://www.google.com/Load📈 view plot
⚠️ NO THRESHOLD
379.73 ms
E2E/https://www.google.com/Resident📈 view plot
⚠️ NO THRESHOLD
183,098,572.00
E2E/https://www.google.com/image-cache📈 view plot
⚠️ NO THRESHOLD
35,328.00
E2E/https://www.servo.org/Load📈 view plot
⚠️ NO THRESHOLD
1,025.47 ms
E2E/https://www.servo.org/Resident📈 view plot
⚠️ NO THRESHOLD
261,003,673.00
🐰 View full continuous benchmarking report in Bencher

github-actions[bot] avatar Jun 10 '25 14:06 github-actions[bot]

✨ Try run (#15562670467) succeeded.

github-actions[bot] avatar Jun 10 '25 15:06 github-actions[bot]

🛠 These changes could not be applied onto the latest upstream WPT. Servo's copy of the Web Platform Tests may be out of sync.

servo-wpt-sync avatar Jun 19 '25 11:06 servo-wpt-sync