servo icon indicating copy to clipboard operation
servo copied to clipboard

[meta] Minibrowser

Open atbrakhi opened this issue 1 year ago • 2 comments

First version of minibrowser is here #29976 but there are more improvements we could do. This issue is the todo list for the improvements and new features.

  • [x] Make sure we repaint while typing, even if servo is idle
    • done in #29976
  • [x] Fix hit testing for links
    • done in #29976
  • [x] Repainting is weird right now. For example, once we navigate to a new page, you need to do some mouse event for the location bar to reflect the current top-level URL (to trigger egui repaint).
    • done in #29976
  • [x] Decide how to deduplicate clipboard-win 2.2.0 and 4.5.0
    • we can contribute a dependency update to clipboard
    • we can make the winit port drop clipboard in favour of arboard
      • done in #30274
  • [ ] Add a help screen that documents the keyboard shortcuts in Browser::handle_key_from_window
  • [x] Make CMD_OR_CONTROL+L focus the location bar when in minibrowser mode
    • done in #30105
  • [x] Make return key equivalent to go button when location field is focused
    • done in #30126
  • [ ] Make enter key equivalent to go button when location field is focused
  • [ ] CursorMoved events in WR viewport area may result in extra egui/WR updates via EventResponse.repaint?
  • [x] #30312
    • done in #30322
  • [ ] #30331
  • [ ] #30332
  • [x] Add buttons to go back and forward
    • done in https://github.com/servo/servo/pull/30805
  • [x] the location sometimes reverts to the old value while loading
    • done in #30518
  • [x] #30341
    • [x] #30340
    • [x] #30342
    • [x] #30344
    • [x] done in #30343
  • [x] #30360
  • [x] Enable Minibrowser by default (also add an option to disable it)
    • done in #30338
  • [x] Location bar is not handling URL without scheme properly
    • [x] #30163
    • [x] #30238
    • [x] #30148
  • [x] #30347
  • [ ] #30696

cc @delan

atbrakhi avatar Jul 31 '23 12:07 atbrakhi

UI locks up when running TWGL Tunnel

Works fine for me. Tested on MacOS

atbrakhi avatar Aug 17 '23 13:08 atbrakhi

UI locks up when running TWGL Tunnel

Works fine for me. Tested on MacOS

Ah I see what you mean. When TWGL example is running, I had to click on the page area to reproduce.

atbrakhi avatar Aug 18 '23 11:08 atbrakhi