servo icon indicating copy to clipboard operation
servo copied to clipboard

Intermittent failure in /_mozilla/css/incremental_trailing_whitespace_a.html

Open wafflespeanut opened this issue 9 years ago • 17 comments

▶ FAIL [expected PASS] /_mozilla/css/incremental_trailing_whitespace_a.html └ → /_mozilla/css/incremental_trailing_whitespace_a.html da54041086f2975f8e3c776d2283ad6609e6862a /_mozilla/css/incremental_trailing_whitespace_ref.html f5d0147c8bddbdc772a7e5e86c7c9e433fcd486b Testing da54041086f2975f8e3c776d2283ad6609e6862a == f5d0147c8bddbdc772a7e5e86c7c9e433fcd486b

wafflespeanut avatar Apr 08 '16 06:04 wafflespeanut

My internet's too slow. Can someone copy-paste the log into the reftest analyzer and capture a screenshot?

ghost avatar Apr 08 '16 06:04 ghost

Seems like the border isn't rendered, probably an incremental layout bug.

incremental-trailing-whitespace

cc @mbrubeck

emilio avatar Apr 08 '16 13:04 emilio

:( I was afraid of this. See https://github.com/servo/servo/pull/10246#issue-144074395 for details. We should probably disable this until #10245 is implemented, and see if that can make it more reliable.

mbrubeck avatar Apr 08 '16 17:04 mbrubeck

Filed #11069 to disable.

mbrubeck avatar May 07 '16 16:05 mbrubeck

Huh, this doesn't look like it's disabled...

KiChjang avatar Oct 17 '16 21:10 KiChjang

Can't we just spinloop for 200ms or something? Edit: nevermind you addressed that in the other ticket.

nox avatar Nov 19 '16 00:11 nox

Wait, we support transitionend now right? So we can just wait for that event in the test.

nox avatar Nov 19 '16 00:11 nox

Yes.

jdm avatar Nov 19 '16 03:11 jdm

@jdm According to http://testthewebforward.org/docs/reftests.html, we can't actually wait for anything in a reftest in Servo, given we don't support mutation observers, no? :(

nox avatar Nov 19 '16 12:11 nox

We have the reftest-wait classname in the HTML element, isn't that enough?

emilio avatar Nov 19 '16 12:11 emilio

No @emilio, we don't support mutation observers.

technical note: the implementation in wptrunner uses mutation observers so the screenshot will be triggered in the microtask checkpoint after the class is removed

nox avatar Nov 19 '16 12:11 nox

We support reftest-wait in rust code

Ms2ger avatar Nov 19 '16 13:11 Ms2ger

PR to disable: #14288.

Ms2ger avatar Nov 20 '16 00:11 Ms2ger

This test is still disabled.

nox avatar Oct 01 '17 11:10 nox

Oops.

nox avatar Oct 01 '17 11:10 nox

This is no longer disabled in layout 2020, so I'm going to close this one.

mrobinson avatar Jul 24 '24 14:07 mrobinson

Seems intermittent again: https://github.com/servo/servo/actions/runs/11061095878/job/30733506496

Stable unexpected results (1): 
  ▶ FAIL [expected PASS] /_mozilla/css/incremental_trailing_whitespace_a.html
  │   → /_mozilla/css/incremental_trailing_whitespace_a.html ['80843029736b498c00cf146d94447f8d935028d1']
  └   → /_mozilla/css/incremental_trailing_whitespace_ref.html ['adf234fc064104ede8499e0b07c49fa532f18ac9']

Loirooriol avatar Sep 26 '24 23:09 Loirooriol

We haven't seen this for months, so I think we are safe to close this again.

mrobinson avatar May 22 '25 15:05 mrobinson