homu icon indicating copy to clipboard operation
homu copied to clipboard

Make r+ by a delegatee infer the delegator

Open jdm opened this issue 9 years ago • 2 comments

This will prevent a common source of incorrect historical metadata in the commit log.

jdm avatar Apr 27 '16 11:04 jdm

So you want the commit history to say "r=Manishearth" if I delegate=Foo on a PR? Delegate isn't just used for this purpose, though (on Rust we're using it to train people)

I instruct folks to @bors r=Manishearth if I delegate.

Perhaps only delegate+ (not delegate=) followed by r+ should make the delegator appear as the reviewer?

Manishearth avatar Apr 27 '16 11:04 Manishearth

Oh yeah, I forgot about the granting of power to non-reviewer folk. delegate+ as a heuristic makes sense to me.

jdm avatar Apr 27 '16 12:04 jdm