homu icon indicating copy to clipboard operation
homu copied to clipboard

Published 20 hours ago • verified publisher icon servo

Buildbot 0.9 support

Open str4d opened this issue 7 years ago • 6 comments

Buildbot 0.9 replaced their ad-hoc API with a JSON-RPC REST interface. This PR adds support for transparently using the v2 API if available, and falling back to the v1 API.

This change is Reviewable

str4d avatar May 10 '17 22:05 str4d

I implemented and tested this as part of upgrading our CI system at https://ci.z.cash/ to Buildbot 0.9. However, I expect it needs significantly-more testing, especially to ensure that the v1 API code is unchanged.

str4d avatar May 10 '17 22:05 str4d

r? @edunham or @aneeshusa

Probably don't have time myself to look through all this. May get to it eventually.

Manishearth avatar May 10 '17 22:05 Manishearth

Oh, side-note: v2 support is currently broken without the fix in https://github.com/buildbot/buildbot/issues/3180 (which I'm currently applying as a patch to buildbot 0.9.7 in our CI).

str4d avatar May 10 '17 23:05 str4d

@str4d please make sure the refactor passes flake8 -- https://travis-ci.org/servo/homu/jobs/230962270

edunham avatar May 15 '17 16:05 edunham

My vote would be removing the explicit BuildBot support - particularly now that (I believe) Rust no longer uses it. Instead, change your BuildBot configuration to write github status hooks. Then, no special support for BuildBot is necessary in Homu - all build systems are equal.

cgwalters avatar May 15 '17 16:05 cgwalters

:umbrella: The latest upstream changes (presumably #117) made this pull request unmergeable. Please resolve the merge conflicts.

bors-servo avatar Jun 15 '17 02:06 bors-servo