highfive icon indicating copy to clipboard operation
highfive copied to clipboard

Published 20 hours ago • verified publisher icon servo

Add S-needs-code-changes if travis build fails

Open wafflespeanut opened this issue 8 years ago • 8 comments

This is a rebase of #88.

wafflespeanut avatar May 27 '16 08:05 wafflespeanut

Heads up! This PR modifies the following files:

  • @jdm: handlers/status_update/init.py, travisciapiprovider.py, eventhandler.py, handlers/status_update/tests/build_status.json, newpr.py

highfive avatar May 27 '16 08:05 highfive

New code was committed to pull request.

highfive avatar May 27 '16 08:05 highfive

New code was committed to pull request.

highfive avatar May 27 '16 09:05 highfive

New code was committed to pull request.

highfive avatar May 27 '16 09:05 highfive

New code was committed to pull request.

highfive avatar May 29 '16 14:05 highfive

New code was committed to pull request.

highfive avatar May 29 '16 14:05 highfive

@jdm I'm not sure whether you're gonna like this, because I couldn't find a way to have a module for TravisCiApiProvider without a circular dependency (and test it at the same time) without duplicating code (especially because it should be initialized at extract_globals_from_payload).

The easier solution was to integrate extract_globals_from_payload and the travis payload parsing into APIProvider itself, so that we can reuse the methods whenever we want.

wafflespeanut avatar May 29 '16 14:05 wafflespeanut

:umbrella: The latest upstream changes (presumably #125) made this pull request unmergeable. Please resolve the merge conflicts.

bors-servo avatar Jun 20 '16 13:06 bors-servo