heapsize icon indicating copy to clipboard operation
heapsize copied to clipboard

Remove implementations for Arc and Vec<Rc>

Open jdm opened this issue 7 years ago • 4 comments

It is better to have no measurements rather than blatantly incorrect ones.


This change is Reviewable

jdm avatar Jul 17 '17 14:07 jdm

r=me with a semver-breaking version number change.

CC https://github.com/servo/heapsize/issues/37

SimonSapin avatar Jul 17 '17 14:07 SimonSapin

I figured it would be rolled in with the number change in #84.

jdm avatar Jul 17 '17 14:07 jdm

Ok, I’m fine with landing this as long as we don’t forget.

CI is still failing with https://github.com/servo/heapsize/issues/86, though.

SimonSapin avatar Jul 17 '17 15:07 SimonSapin

Sounds like #84 is not happening, and I don’t feel like going through all reverse dependencies to increment the version number just for this.

SimonSapin avatar Jul 19 '17 11:07 SimonSapin