core-foundation-rs icon indicating copy to clipboard operation
core-foundation-rs copied to clipboard
verified publisher icon servo

Update `bitflags` to 2.2.1

Open burtonageo opened this issue 2 years ago • 5 comments

Splits out the bitflags part of https://github.com/servo/core-foundation-rs/pull/545

burtonageo avatar Apr 25 '23 21:04 burtonageo

@bors-servo r+

jdm avatar May 19 '23 02:05 jdm

:pushpin: Commit 0fb387a has been approved by jdm

bors-servo avatar May 19 '23 02:05 bors-servo

:hourglass: Testing commit 0fb387abbdf9a5581ff0a54bc952c168eb628349 with merge 048c24a0baf29f41bb50e003d6d572fbb1feb091...

bors-servo avatar May 19 '23 02:05 bors-servo

:broken_heart: Test failed - checks-github

bors-servo avatar May 20 '23 16:05 bors-servo

:umbrella: The latest upstream changes (presumably b009c87f2da0038bb474800cd88597843e5dbdae) made this pull request unmergeable. Please resolve the merge conflicts.

bors-servo avatar Jul 25 '23 02:07 bors-servo

This causes semver checks to start failing because fn from_bits_unchecked(...) is no longer exposed on bitflags types.

mrobinson avatar Apr 06 '24 09:04 mrobinson

I have rebaesed this PR, so assuming it passes all CI jobs I'll land it. The only substantive change I have made to the original version is to specify bitflags = "2" for the version instead of the exact version. This should make it slightly more compatible with other projects that use different versions of bitflags.

mrobinson avatar Apr 09 '24 08:04 mrobinson