core-foundation-rs icon indicating copy to clipboard operation
core-foundation-rs copied to clipboard
verified publisher icon servo

fix: add animate property to NSWindow:setFrame:

Open keiya01 opened this issue 3 years ago • 5 comments

I added animate property to NSWindow:setFrame:. If this behavior is intended, I'm sorry but please close this PR.

keiya01 avatar Jun 27 '22 05:06 keiya01

-[NSWindow setFrame:display:] and -[NSWindow setFrame:display:animate:] are different methods, so I think you should add setFrame_display_animate_ instead of changing the existing setFrame_display_.

I see. I fixed your review.

keiya01 avatar Jun 27 '22 23:06 keiya01

@bors-servo r+

jdm avatar Aug 15 '22 12:08 jdm

:pushpin: Commit 0df00e0 has been approved by jdm

bors-servo avatar Aug 15 '22 12:08 bors-servo

:hourglass: Testing commit 0df00e0543b19a6b3b598793bdeb97fee699bd21 with merge b4f9fcf836b74d9644691bc252ae84a09a3d1cb4...

bors-servo avatar Aug 15 '22 12:08 bors-servo

:boom: Test timed out

bors-servo avatar Aug 15 '22 22:08 bors-servo

@bors-servo retry

jdm avatar Aug 17 '22 01:08 jdm

:hourglass: Testing commit 0df00e0543b19a6b3b598793bdeb97fee699bd21 with merge bb8852eff82a148248e1bcdeedb8a7efdeb6985e...

bors-servo avatar Aug 17 '22 01:08 bors-servo

:sunny: Test successful - checks-github Approved by: jdm Pushing bb8852eff82a148248e1bcdeedb8a7efdeb6985e to master...

bors-servo avatar Aug 17 '22 01:08 bors-servo