core-foundation-rs icon indicating copy to clipboard operation
core-foundation-rs copied to clipboard

Published 20 hours ago • verified publisher icon servo

Bump version for cocoa-rs (New Publish Required)

Open WalrusSoup opened this issue 2 years ago • 7 comments

Sets cocoa-rs to version 0.25.0 to solve https://github.com/servo/core-foundation-rs/issues/504.

WalrusSoup avatar Apr 11 '22 16:04 WalrusSoup

Can this just be 0.24.1? Were there any breaking changes since the last release?

jrmuizel avatar Apr 11 '22 17:04 jrmuizel

Edit: Reverted this back to 0.25.0 as JDM noted below. Changes were rolled into other releases. I misinterpreted the relationships between packages as I assumed that core-foundation could not introduce a breaking change in it's crate given that the cargo for cocoa-rs specifies core-foundation 0.9. Strange...

WalrusSoup avatar Apr 11 '22 18:04 WalrusSoup

https://github.com/servo/core-foundation-rs/commit/147a432fa91b48726d7eebded9e65e58e1f077ae and https://github.com/servo/core-foundation-rs/commit/39e1e0eeef11a17cf49aa6a500c37e665d967d2a were breaking changes.

jdm avatar Apr 11 '22 18:04 jdm

I reverted this back to using the 0.25.0 version due to those PR's. Anything else I can contribute to move this forward?

WalrusSoup avatar Apr 12 '22 16:04 WalrusSoup

Can squash things down to a single commit?

jrmuizel avatar Apr 12 '22 17:04 jrmuizel

I have squashed them but it's not reflecting in this PR, oddly enough.

I believe a squash and merge should be available when merging, or I can close this one and open another PR. Whichever is fine.

WalrusSoup avatar Apr 12 '22 19:04 WalrusSoup

Hey @WalrusSoup,

This PR hasn't changed state for two months. Why is this not merged yet? At this point, I am lucky because it looks like #512 will make it into 0.25.0. What is left to get it merged and the new version published?

Hupka avatar Jun 10 '22 08:06 Hupka

Hey @WalrusSoup,

This PR hasn't changed state for two months. Why is this not merged yet? At this point, I am lucky because it looks like #512 will make it into 0.25.0. What is left to get it merged and the new version published?

I believe i did what was asked, so no idea. it should probably be closed if its stale.

WalrusSoup avatar Oct 06 '22 17:10 WalrusSoup

Hello @jrmuizel can we please release this new version of cocoa (0.25.0)?

n-eq avatar Oct 20 '22 05:10 n-eq

I was looking more closely and I'd like to understand why https://github.com/servo/core-foundation-rs/commit/39e1e0eeef11a17cf49aa6a500c37e665d967d2a and https://github.com/servo/core-foundation-rs/commit/147a432fa91b48726d7eebded9e65e58e1f077ae are breaking changes?

@jdm?

jrmuizel avatar Oct 20 '22 14:10 jrmuizel

https://github.com/servo/core-foundation-rs/commit/39e1e0eeef11a17cf49aa6a500c37e665d967d2a is a breaking change because the user likely only imported NSOpenPanel, and that doesn't allow them to call the supertrait's methods, see playground link - note that this can be remedied by re-adding the method to NSOpenPanel (and perhaps mark it as deprecated).

https://github.com/servo/core-foundation-rs/commit/147a432fa91b48726d7eebded9e65e58e1f077ae is a clear bugfix and didn't work at all before, so while it is breaking public API, no-one could have used it without their program being broken.

madsmtm avatar Oct 23 '22 21:10 madsmtm

@madsmtm but 0.24 doesn't have NSOpenPanel bindings. There hasn't been a stable release the exposed NSOpenPanel.

jrmuizel avatar Oct 30 '22 18:10 jrmuizel

Ah, you're right, then never mind

madsmtm avatar Oct 31 '22 21:10 madsmtm

@madsmtm do you mind making a PR dropping the version from 0.25.0 down to 0.24.1?

jrmuizel avatar Nov 01 '22 00:11 jrmuizel

Sure, see https://github.com/servo/core-foundation-rs/pull/527

madsmtm avatar Nov 01 '22 12:11 madsmtm

Published

jrmuizel avatar Nov 01 '22 13:11 jrmuizel