service-mesh-patterns icon indicating copy to clipboard operation
service-mesh-patterns copied to clipboard

Published 20 hours ago • verified publisher icon service-mesh-patterns

[Chapters of the book] Improvements in CTA

Open kamalbuilds opened this issue 2 years ago • 16 comments

Description

1> The icon is very small, make it bigger image

2> There are 2 duplicate CTA's we need to keep only 1.

Expected Behavior

Screenshots/Logs

Environment:

  • Meshery Version:
  • Kubernetes Version:
  • Host OS:
  • Browser:

kamalbuilds avatar Oct 04 '22 03:10 kamalbuilds

@leecalcote @Nikhil-Ladha should we make the second CTA redirect to slack? as both are redirecting to same place.

kamalbuilds avatar Oct 04 '22 03:10 kamalbuilds

I would love to work on this @legendarykamal .

sam1code avatar Oct 04 '22 03:10 sam1code

@sam1code it'd be good to see the other four that you have assigned completed first (or at least of all them under PR review).

leecalcote avatar Oct 04 '22 03:10 leecalcote

Yes only one remaining I'll be creating pr of that one in some times

sam1code avatar Oct 04 '22 04:10 sam1code

Can I work over this if it still exist?

TiwariAbhishek23 avatar Oct 13 '22 18:10 TiwariAbhishek23

You can work on this issue @AbhishekTiwari23 . Though, not that the requirement (noting @legendarykamal suggestion) is to change to callout to "Layer5 Slack Workspace" with the slack icon (whitewashed) in the beginning (just like now).

Nikhil-Ladha avatar Oct 13 '22 18:10 Nikhil-Ladha

@legendarykamal sir, can you please share the ink for that page where I have to make changes. It will be thankful for me.

TiwariAbhishek23 avatar Oct 13 '22 19:10 TiwariAbhishek23

Is it this one ? Screenshot 2022-10-14 at 12 45 15 AM

TiwariAbhishek23 avatar Oct 13 '22 19:10 TiwariAbhishek23

Oh, now I get it. I apologise for the inconvenience

TiwariAbhishek23 avatar Oct 13 '22 19:10 TiwariAbhishek23

Hello @legendarykamal @Nikhil-Ladha, sir, this is my first time when am contributing to this repo, and I am trying but not able to set it up on localhost. Can u please guide me? I followed all the steps of contributing.MD file, and there are no steps mentioned for this. I will be thankful if you guide me.

TiwariAbhishek23 avatar Oct 14 '22 11:10 TiwariAbhishek23

Just navigate to the site directory and execute the npm install and npm start commands. That should do the job.

Nikhil-Ladha avatar Oct 18 '22 10:10 Nikhil-Ladha

https://user-images.githubusercontent.com/97469132/196407085-ad1a9945-4ba7-45a6-b3cc-35f61babc3f7.mov

Is it fine?

TiwariAbhishek23 avatar Oct 18 '22 10:10 TiwariAbhishek23

@debo19 I forgot your suggestion for the callout on this page, can you please re-iterate here?

Nikhil-Ladha avatar Oct 19 '22 10:10 Nikhil-Ladha

Just change the content on the second callout to point to something else like layer5.io/projects or layer5.io/learn/learning-paths

debo19 avatar Oct 19 '22 19:10 debo19

@UtkarshMishra12

leecalcote avatar Nov 12 '22 13:11 leecalcote

Is this issue still valid? @legendarykamal

eeshaanSA avatar Dec 22 '22 13:12 eeshaanSA