servicebot
servicebot copied to clipboard
Suspended users can still be charged
Ways users can be charged while suspended
Current functionality cancels all services a user has if they become suspended. There are still some gaps that could allow for a user to be charged even when suspended (badddd)
- Restart a cancelled service
- Request a service for a suspended user
- Editing a payment plan on a cancelled service for a suspended user
- If a user has a cancellation request active when suspended, the admin can reject that request which will reactivate the service
Solution
- [ ] Disable all payment actions on server for suspended user (protects apis and final failsafe if client can't resolve)
- [ ] Don't allow editing of a cancelled service payment plan AT ALL
- [x] Make sure to not allow for restarting of a service for a suspended user
- [x] ~~Do not show suspended users on the "request for"~~
- [ ] Do not allow to add a card to a suspended user (small polish)
- [x] ~~Fix #237~~
- [ ] Do not allow approval of charges on an instance which the user is suspended
This is great find, Ben. I will need to look into the code to see how long it will take for the Client part.
Most major cases are covered for 0.7.0 release. Rest will be moved to next release.