docker-php icon indicating copy to clipboard operation
docker-php copied to clipboard

Add creating missing SQLite database files

Open DarkGhostHunter opened this issue 1 year ago • 4 comments

This PR allows the container to start and create missing the SQLite databases set by the application.

It's part of the container AUTORUN_LARAVEL scripts. It runs before the migrations. Is opt-in by default, mostly because usually production apps run on non-SQLite but PR/preview/staging apps sometimes do spin SQLite for testing or pure convenience.

The way it works is through the AUTORUN_LARAVEL_TOUCH_SQLITE environment value, which by default is false:

  • When true, 1 or default, it will pick the default connection.
  • When used as default, telescope, custom, it will find the connection names, and create each database file.

This is done by checking if the driver is sqlite and the file doesn't exist. If it's not SQLite, it fails. If the database file already exists, doesn't do anything.

[!NOTE] Newer Laravel versions do create the SQLite database file when force migrating. Outside that command, it won't.

DarkGhostHunter avatar Jul 11 '24 16:07 DarkGhostHunter

Thanks for the PR on this. I just ran into this issue myself.

Regarding your comment:

Newer Laravel versions do create the SQLite database file when force migrating. Otherwise, it won't.

Do you know what version this started happening in?

jaydrogers avatar Jul 18 '24 00:07 jaydrogers

I believe 9.x or 8.x, I'll have to see the blame.

DarkGhostHunter avatar Jul 18 '24 01:07 DarkGhostHunter

Thanks!

If it goes back that far with Laravel, should we even merge this?

I was able to resolve my issue by having proper permissions on my Docker Volumes with Laravel 11. Once I had the correct permissions, the auomations worked perfectly and created my database.

jaydrogers avatar Jul 18 '24 01:07 jaydrogers

Thanks!

If it goes back that far with Laravel, should we even merge this?

I was able to resolve my issue by having proper permissions on my Docker Volumes with Laravel 11. Once I had the correct permissions, the auomations worked perfectly and created my database.

9.31 https://github.com/laravel/framework/pull/44153

It doesn't go that far IMHO. In any case, I think older Laravel apps would benefit from this on staging and development, especially if you are on the path to upgrade.

DarkGhostHunter avatar Jul 18 '24 01:07 DarkGhostHunter

Thanks for your efforts on this PR!

As I mentioned in the other post, I spent a ton of time refactoring the Laravel Automations script:

  • https://github.com/serversideup/docker-php/pull/283

What's new in my refactor

I decided to NOT include a "touch" for creating SQLite database file.

My reason

Laravel will create this for you automatically with php artisan migrate. I did not want to step on Laravel's toes with this process.

Instead, you can see that I added helpful logic to help debug if a SQLite file does not exist when we test the DB connection: https://github.com/serversideup/docker-php/blob/280-create-a-frankenphp-variation/src/common/etc/entrypoint.d/lib/laravel/test-db-connection.php

Let me know your thoughts on my approach. I greatly appreciate your intentions on this PR and would gladly review any other improvements that you suggest 👍

jaydrogers avatar Oct 07 '25 16:10 jaydrogers