amplitudejs icon indicating copy to clipboard operation
amplitudejs copied to clipboard

Amplitude.getAnalyser() returning null

Open feemcgill opened this issue 5 years ago • 5 comments

Issue description

getAnalyser() returns null unless

<div class="amplitude-wave-form"></div> Or <div class="amplitude-visualization"></div> Are present on the page.

I had removed my waveform due to this IOS issue https://github.com/521dimensions/amplitudejs/issues/389

And now my analyser is broke!

Environment

Chrome: https://whatsmybrowser.org/b/JS36SQH

  • Amplitude.js Version: "5.0.2"

What is expected?

Would love to get the analyser on its own without waveform or AmplitudeJS registered visualization

Link to where issue can be reproduced

Additional details / screenshots

Screen Shot 2020-01-17 at 4 19 09 PM

feemcgill avatar Jan 18 '20 00:01 feemcgill

Ah okay, AmplitudeJS only initializes the analyser if there is a use for it: https://github.com/521dimensions/amplitudejs/blob/master/src/fx/fx.js#L43. There were issues with the Web Audio API breaking other situations where devs weren't even using it, so I scoped it only if they needed it.

Let me run some tests to see if just initializing it without connecting to the source causes issues.

danpastori avatar Jan 18 '20 18:01 danpastori

Hi @danpastori if someone is not working on it and its still requires some help can you assign this to me?

ShlokJswl avatar Jan 25 '23 05:01 ShlokJswl

@ShlokJswl: Thanks for chiming in.

@danpastori's been busy writing our new book, so unfortunately that means AmplitudeJS won't get updates until later in 2023.

You can see his latest efforts here: https://github.com/serversideup/amplitudejs/pull/514

jaydrogers avatar Jan 25 '23 14:01 jaydrogers

@ShlokJswl: Thanks for chiming in.

@danpastori's been busy writing our new book, so unfortunately that means AmplitudeJS won't get updates until later in 2023.

You can see his latest efforts here: #514

@jaydrogers Hello Jay, thanks for the info, is it still okay for me to work on this issue if it's not fixed?

ShlokJswl avatar Jan 26 '23 09:01 ShlokJswl

I would suggest to start working on it only if @danpastori says so.

There are so many changes in Amplitude 6, I'd hate to have you go through the work and not have it get released.

jaydrogers avatar Jan 26 '23 15:01 jaydrogers