synapse icon indicating copy to clipboard operation
synapse copied to clipboard

Published 20 hours ago • verified publisher icon serverlessworkflow

DSL v1.0.0-alpha1

Open cdavernas opened this issue 1 year ago • 3 comments
trafficstars

Many thanks for submitting your Pull Request :heart:!

What this PR does / why we need it:

Implements the Serverless Workflow v1.0.0-alpha1

cdavernas avatar May 26 '24 12:05 cdavernas

@JBBianchi could you sign-off your changes and fix the null ref warnings in the Dashboard?

cdavernas avatar Jul 01 '24 20:07 cdavernas

@cdavernas I fixed the warnings.

For the sign-off, I did it. The problem is that "JBBianchi" (author) didn't match "Jean-Baptiste Bianchi" (sign-off). I changed my git config to author my commits as Jean-Baptiste Bianchi now so the bot won't complain anymore. For the previous commits, I'm a bit afraid of rewriting the history as it can lead to a big git mess as we both worked on that branch. Should I take the risk ?

JBBianchi avatar Jul 02 '24 09:07 JBBianchi

@JBBianchi Nah dont worry, it's OK, I'll set DCO to pass then ;) Thank you for the warning fixes ❤️

cdavernas avatar Jul 02 '24 09:07 cdavernas