Examples README samples are broken

[JBBianchi]

trafficstars

What seems off: The include of example sample seems to break the readme layout:

What you expected to be: The layout to be nice and clean.

[ricardozanini]

Hey @JBBianchi thanks for reporting it! Are you willing to fix it? :D

[JBBianchi]

Yes, it's just a line return that needs to be added.

[RamiKassouf]

It's broken again

[JBBianchi]

It's broken again

It hasn't been regenerated so far, so it's "still" broken :)

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[ricardozanini]

@JBBianchi is this fixed?

[JBBianchi]

@JBBianchi is this fixed?

When https://github.com/serverlessworkflow/specification/pull/836 is merged we'll know for sure, but it should be.

[JBBianchi]

It looks like the workflow to hydrate the readme is broken: https://github.com/serverlessworkflow/specification/actions/workflows/examples-readme-hydration.yml

Either because the BOT_PAT secret is missing or the bot doesn't have the rights on the repository.

[ricardozanini]

That's weird, I'll take a look later

[cdavernas]

@JBBianchi @ricardozanini Can you fix that for 0.9, meaning now, or should we close it as part of #843 ?

[JBBianchi]

I think it would be a good thing to fix the bot config. Even if the examples are dropped with the next version, we'll still need a functioning bot in the future.

[cdavernas]

@ricardozanini Can you please address that?

[ricardozanini]

Closing this since we don't have this pipeline nor the examples README anymore.

[cdavernas]

I think this must be fixed on 0.9.0

[ricardozanini]

@cdavernas I'll reopen but it might stale. I'd keep it close and if there's momentum we'll notice since the CI will fail, then we can fix it. I'm investing my time on 1.0.0 atm. Feel free to reopen.

[cdavernas]

I'm investing my time on 1.0.0 atm

Not shit! 😆 Me too 🎉