specification icon indicating copy to clipboard operation
specification copied to clipboard

Simplify data filter property names

Open cdavernas opened this issue 3 years ago • 11 comments
trafficstars

Many thanks for submitting your Pull Request :heart:!

Please specify parts of this PR update:

  • [x] Specification
  • [x] Schema
  • [x] Examples
  • [ ] Extensions
  • [ ] Roadmap
  • [ ] Use Cases
  • [ ] Community
  • [ ] TCK
  • [ ] Other

Discussion or Issue link: https://github.com/serverlessworkflow/specification/issues/672

What this PR does / why we need it: Simplifies data filter property names, which are uselessly verbose

Special notes for reviewers: The change applies to all concepts, except for the callbackState which exposes two filters at top level (stateDataFilter and eventDataFilter), which should anyways disapear if we go through with atomic produce/consume actions. If we keep the callbackState, we should then move the eventDataFilter down an event property, to ensure coherence accross the spec.

cdavernas avatar Oct 24 '22 15:10 cdavernas

thanks for pr! def +1 but would like if possible to wait till we deal with callback state what we have now (before this change) is more verbose yes but consistent across all workflow states for filters

this change even tho again +1 would put spec in an inconsistent state until like you mentioned we deal with the callback state which still with your changes includes:

   "eventDataFilter": {
            "description": "Event data filter",
            "$ref": "#/definitions/eventdatafilter"
          },
          "stateDataFilter": {
            "description": "State data filter",
            "$ref": "#/definitions/statedatafilter"
          },

Are you ok with leaving this up and then add it as soon as we figure out the callback state questions?

tsurdilo avatar Oct 26 '22 04:10 tsurdilo

@tsurdilo yeah, sure! It's just a cosmetic update anyways ;)

cdavernas avatar Oct 26 '22 06:10 cdavernas

roadmap update reminder :)

tsurdilo avatar Nov 28 '22 16:11 tsurdilo

Will do asap, thanks!

cdavernas avatar Dec 04 '22 20:12 cdavernas

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jan 19 '23 00:01 github-actions[bot]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Mar 06 '23 00:03 github-actions[bot]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Apr 21 '23 00:04 github-actions[bot]

@tsurdilo The roadmap has finally been updated ;) Sorry for the very long delay, had forgot about the PR

cdavernas avatar May 30 '23 09:05 cdavernas

@tsurdilo can you please take a look?

ricardozanini avatar May 30 '23 13:05 ricardozanini

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jul 15 '23 00:07 github-actions[bot]

Have to refactor that one too :(

Not surprisingly, became stale after like 2 years of sitting here

cdavernas avatar Feb 16 '24 08:02 cdavernas

Closed as part of https://github.com/serverlessworkflow/specification/issues/843

ricardozanini avatar May 16 '24 15:05 ricardozanini