sdk-net icon indicating copy to clipboard operation
sdk-net copied to clipboard

Suggest remove the Extensions

Open wjqdst opened this issue 1 year ago • 3 comments
trafficstars

WXWorkCapture_17267126618091 WXWorkCapture_17267126522149 WXWorkCapture_17267126146476 Hi, Because now in the TaskDefinition have 2 EquatableDictionary parameter, 1 is Extensions another is Metadata, but if we use odata it will casue error, and I see in the document we just have Metadata do not have Extensions, so I suggest to remove the Extensions parameter. Thanks.

wjqdst avatar Sep 19 '24 02:09 wjqdst

when will the issue be resolved? @cdavernas

evil116 avatar Sep 20 '24 06:09 evil116

@evil116 Not before next week as I'm in PTO. If that's a problem, you are welcome to open a PR 😉

On a side note, @wjqdst @evil116 please be so kind to star the project to show your support!

cdavernas avatar Sep 20 '24 07:09 cdavernas

@cdavernas noted with thanks, when you work next week, please let us know whether your team will fix this and when will have a new release for this. 😉

wjqdst avatar Sep 20 '24 07:09 wjqdst

@cdavernas may I know this progress

wjqdst avatar Sep 25 '24 09:09 wjqdst

Still on PTO. As said, I'll try to solve it this week 😉 I'll keep you posted.

In the meanwhile, please do drop a star 🙏

cdavernas avatar Sep 25 '24 09:09 cdavernas

noted, already drop.

wjqdst avatar Sep 25 '24 09:09 wjqdst

@cdavernas may I know the progress again

wjqdst avatar Oct 01 '24 06:10 wjqdst

Merging in progress.

On a side note, and even though the extensions property was not required anymore, the metadata one should NOT be considered as an ODATA extension property: unlike extensions, it should be queryable just like any other top level properties. To do so, you'd need to register EquatableDictionary<string, object> as a new complex type, or using a surrogate list type (ex: KvpList<T>)

cdavernas avatar Oct 01 '24 07:10 cdavernas