sdk-go icon indicating copy to clipboard operation
sdk-go copied to clipboard

fix(121): split inject state to separate file

Open lsytj0413 opened this issue 2 years ago • 2 comments

Signed-off-by: lsytj0413 [email protected]

Many thanks for submitting your Pull Request :heart:!

What this PR does / why we need it:

Special notes for reviewers:

Additional information (if needed):

Fixed https://github.com/serverlessworkflow/sdk-go/issues/121

lsytj0413 avatar Oct 25 '22 09:10 lsytj0413

Hold by https://github.com/serverlessworkflow/specification/pull/703

lsytj0413 avatar Oct 25 '22 11:10 lsytj0413

we already have this timeouts for a while, why is it dependent?

Yes, base on v0.8 we can confirm the timeouts property is exists. We can merge this now.

lsytj0413 avatar Oct 25 '22 12:10 lsytj0413

cc @ricardozanini PTAL

lsytj0413 avatar Nov 02 '22 11:11 lsytj0413

@lsytj0413 can you please rebase? I'm on PTO, so I have limited access to GH.

ricardozanini avatar Nov 02 '22 12:11 ricardozanini

@lsytj0413 can you please rebase? I'm on PTO, so I have limited access to GH.

done, PTAL

lsytj0413 avatar Nov 03 '22 01:11 lsytj0413

/lgtm

ricardozanini avatar Nov 14 '22 14:11 ricardozanini