sdk-go icon indicating copy to clipboard operation
sdk-go copied to clipboard

Add Prow bot style tool to automate PR/Issue workflow

Open lsytj0413 opened this issue 2 years ago • 3 comments

What would you like to be added:

  • use https://github.com/kubernetes/test-infra/tree/master/prow style tool to automate PR merging and other job.

Why is this needed:

lsytj0413 avatar Oct 22 '22 02:10 lsytj0413

Perhaps https://github.com/jpmcb/prow-github-actions/issues is helpful.

lsytj0413 avatar Oct 24 '22 06:10 lsytj0413

That would be awesome. I believe I also have a new issue related to this one to include checks against the spec's scheme in the CI too.

ricardozanini avatar Oct 24 '22 14:10 ricardozanini

Can you explain a little more, I'm not very clear what you mean.

lsytj0413 avatar Oct 25 '22 04:10 lsytj0413

The idea is to download the scheme/examples from the main repo (https://github.com/serverlessworkflow/specification) and include specific integration tests with those assets.

ricardozanini avatar Nov 02 '22 12:11 ricardozanini

The idea is to download the scheme/examples from the main repo (https://github.com/serverlessworkflow/specification) and include specific integration tests with those assets.

The most problem is the example have been embedded in README.md file's content, in order to archive this goal, we should move example's schema file to another separate directory.

lsytj0413 avatar Nov 03 '22 01:11 lsytj0413

This is a valid improvement.

spolti avatar Nov 03 '22 14:11 spolti

The idea is to download the scheme/examples from the main repo (https://github.com/serverlessworkflow/specification) and include specific integration tests with those assets.

The most problem is the example have been embedded in README.md file's content, in order to archive this goal, we should move example's schema file to another separate directory.

https://github.com/serverlessworkflow/specification/issues/324 is doing this.

lsytj0413 avatar Nov 08 '22 02:11 lsytj0413