sdk-go icon indicating copy to clipboard operation
sdk-go copied to clipboard

Valid parsed workflow cannot be unmarshalled after being marshalled to JSON

Open obloquy opened this issue 2 years ago • 4 comments

What happened: I'm working on integrating serverlessworkflow and Temporal and using the current main branch of the serverlessworkflow sdk (b9db1ddbffb2). I'm trying to pass a parsed serverlessworkflow to a Temporal workflow. This leads the Temporal SDK to go through a marshal/unmarshal cycle which fails to unmarshal some recent Auth def changes in the serverlessworkflow.

What you expected to happen: I would expect the marshal/unmarshal to work as it did for the serverlessworkflow 2.1.2 release

How to reproduce it: Reproduce with the attached source which doesn't require temporal. main.go.gz

Anything else we need to know?:

Environment:

  • Specification version used: latest (serverlessworkflow sdk commit b9db1ddbffb2)
  • Go version: go version go1.17.11 darwin/amd64

obloquy avatar Oct 20 '22 13:10 obloquy

@lsytj0413 @spolti, can you guys take a look, please? Might be related to the recent changes.

ricardozanini avatar Oct 20 '22 18:10 ricardozanini

sure, probably tomorrow.

spolti avatar Oct 20 '22 18:10 spolti

hi, the referred pr fixes the issue, please validate.

spolti avatar Oct 20 '22 22:10 spolti

Cheers. Thanks for the quick turnaround. I can confirm the issue is resolved by #111

obloquy avatar Oct 20 '22 23:10 obloquy