serverless-python-requirements icon indicating copy to clipboard operation
serverless-python-requirements copied to clipboard

Change wording around "Generating requirements.txt from pyproject.toml..."

Open kkom opened this issue 2 years ago • 1 comments

Hey!

So looking at the message in the logs I was concerned that the requirements.txt file was literally generated from pyproject.toml. Which in my mind meant not using the lock file (i.e. poetry.lock) and this resulting in non-deterministic and different environment between local and CI/CD.

Only after reading the docs I realized that what this plugin does is "the right thing", i.e. just call poetry export.

I'm happy to submit a PR to change the wording a little bit to make it less concerning, but first I wanna ask WDYT about it?

Cheers, Konrad

kkom avatar Nov 10 '21 18:11 kkom

Hello @kkom - thanks for reporting :bow: We're definitely open to such improvement :100: It might be an omission where the message is not being updated based on source used for generating/installing requirements.

pgrzesik avatar Nov 11 '21 10:11 pgrzesik