serverless-python-requirements icon indicating copy to clipboard operation
serverless-python-requirements copied to clipboard

Individual requirements should allow pipenv/poetry for functions

Open michael-c-hoffman opened this issue 3 years ago • 4 comments

When using package individually, the requirements are not pulled from a Pipfile/peotry file if present, only requirements.txt (this is a completely different behaviour than when not using package individually as at the root of the project on can use Pipfile/poetry)

If there is a Pipfile/poetry file at the root when using package individually the root level requirements are only packaged not the root+function or just function requirements.

I would like to continue to use Pipfile at the root level as this contains development packages for pytest and other frameworks. I would then like to include a Pipfile in each function that needs to be package with that function's requirements. Currently if serverless-python-requirements detects a Pipfile at the root all other function requirements are ignored.

michael-c-hoffman avatar Dec 11 '20 15:12 michael-c-hoffman

same here with: package: individually: true

if i have a Pipfile in my module it is just ignored

antoinechamot avatar Apr 08 '21 18:04 antoinechamot

What would you expect the layout to look like? For instance:

serverless.yml
module1/
    pyproject.toml
    func1/
        __init__.py
module2/
    Pipfile
    func2/
        __init__.py

bsamuel-ui avatar Apr 11 '21 04:04 bsamuel-ui

yes, that would be the expected layout

michael-c-hoffman avatar Jul 23 '21 05:07 michael-c-hoffman

I also expected to have pyproject.toml & requirements.txt to behave similar: if there's a pyproject.toml in the module directory, it would be used as preprocessing step to create the requirements.txt in the module dir.

However, only a pyproject.toml in the root folder results in creating a requirements.txt (in the root folder)

gerbenoostra avatar Nov 25 '21 13:11 gerbenoostra