serverless-plugin-typescript icon indicating copy to clipboard operation
serverless-plugin-typescript copied to clipboard

Wrong parameter path.copy & fix artifact

Open tomzaku opened this issue 4 years ago • 4 comments

#167

tomzaku avatar Jul 17 '19 08:07 tomzaku

Thanks for doing this, @tomzaku! Your changes look good but do you mind updating your commit message to read fix: wrong parameter path.copy & fix artifact so the release bot can publish the version correctly?

When I have some time this weekend I'll try to repro these issues too :smile:

JackCuthbert avatar Jul 19 '19 00:07 JackCuthbert

@JackCuthbert done!

tomzaku avatar Jul 19 '19 02:07 tomzaku

This appears to be specific to serverless-webpack users. Your fix resolves the issue when someone uses webpack, but breaks non-webpack projects (at least it did for me).

The following error occurs when running your fix without serverless-webpack.

Serverless: Compiling with Typescript...
Serverless: Typescript compiled.
Serverless: Packaging service...
Serverless: Excluding development dependencies...
Unhandled rejection Error: ENOENT: no such file or directory, open '/home/jack/Code/serverless-plugins/.serverless/serverless-typescript-debugging.zip'

Additionally, the serverless offline integration fails with a Cannot find module error during function invocation when using serverless-webpack. I copied as much of your webpack config as I could, is there something I did wrong here to cause this one?

Do you know how we might support both using webpack and a zero-config option with just the TS compiler?

JackCuthbert avatar Jul 21 '19 04:07 JackCuthbert

Any plan to merge this?

ghost avatar Nov 07 '19 15:11 ghost