serverless-google-cloudfunctions icon indicating copy to clipboard operation
serverless-google-cloudfunctions copied to clipboard

Add ability to individually package functions

Open wootencl opened this issue 5 years ago • 8 comments

Quick pass at adding individual packaging functionality. Mostly looked at the AWS implementation and tried to create parity between here and there.

@pmuens Happy to add tests + get linting, etc. in order if this is something you'd be willing to merge. Mostly don't want to sink any more time into this if that's not the case.

Fixes: #89

wootencl avatar Apr 18 '19 23:04 wootencl

would love to see this merged :D

simonasdev avatar May 15 '19 14:05 simonasdev

any news ?

saiaman avatar Jun 14 '19 13:06 saiaman

Quick pass at adding individual packaging functionality. Mostly looked at the AWS implementation and tried to create parity between here and there.

@pmuens Happy to add tests + get linting, etc. in order if this is something you'd be willing to merge. Mostly don't want to sink any more time into this if that's not the case.

Fixes: #89

Can you please patch eslint problems in order to get travis working ?

saiaman avatar Jun 14 '19 13:06 saiaman

@saiaman Feel free to fork my fork and create another PR with the eslint problems resolved if desired. At current I'm unfortunately a bit strapped for time and don't want to invest any more into this particularly with the relative inactivity of this repo.

wootencl avatar Jun 19 '19 16:06 wootencl

@wootencl perhaps assigning other maintainers to the repo would help? I'm willing to give a hand, I'm sure other people would do.

markmssd avatar Jul 14 '19 02:07 markmssd

@wootencl I've tested your changes, it deploys functions properly 👍

Couple of points I noticed:

  • It doesn't work anymore without the individually option
  • All the functions upload with the same .zip size. Is that normal? I suppose it is right?
  • *EDIT: A lot of unit tests are failing

Let's join forces to fix them!

markmssd avatar Jul 14 '19 07:07 markmssd

@markmssd I'll admit, my availability is opening up a bit so could possibly lend a hand in maintaining this repo. Ultimately though, that decision is up to @pmuens.

wootencl avatar Jul 15 '19 14:07 wootencl

Bump.

sushilkg avatar Oct 21 '20 11:10 sushilkg