serverless-azure-functions icon indicating copy to clipboard operation
serverless-azure-functions copied to clipboard

fix: add types to fix deprecation warning

Open dnicolson opened this issue 4 years ago • 4 comments

What did you implement:

This pull request adds types to command line options.

Closes #568

How can we verify it:

Run serverless info and check for deprecation warnings.

Todos:

Note: Run npm run test:ci to run all validation checks on proposed changes

  • [x] Ensure there are no lint errors.
    Validate via npm run lint
    Note: Some reported issues can be automatically fixed by running npm run lint:fix
  • [x] Write tests and confirm existing functionality is not broken.
    Validate via npm test
  • [ ] Write documentation
  • [ ] Provide verification config / commands / resources
  • [x] Enable "Allow edits from maintainers" for this PR
  • [x] Update the messages below

Is this ready for review?: YES Is it a breaking change?: NO

dnicolson avatar Aug 23 '21 20:08 dnicolson

Thank you @dnicolson - it looks good, however, the branch is not up-to-date with `master. Could you please update it so it's either rebased on top of current master or has current master merged into it?

pgrzesik avatar Aug 24 '21 13:08 pgrzesik

Hi @pgrzesik, I updated master a while back but a few days ago https://github.com/serverless/serverless-azure-functions/pull/577 was merged so it needs updating again. The fork has since been deleted, is someone able to merge master into this pull request?

dnicolson avatar Dec 08 '21 19:12 dnicolson

Hello @dnicolson 👋 @tbarlow12 would you be able to help out with that?

pgrzesik avatar Dec 17 '21 08:12 pgrzesik

Bumping this

akurtz avatar Mar 16 '22 20:03 akurtz